added InvalidRequestTokenError error (#253)

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## master
 
+- [#253](https://github.com/castle/castle-ruby/pull/253)
+  * added InvalidRequestTokenError
+
 ## 7.1.2
 
 - [#247](https://github.com/castle/castle-ruby/pull/247)

lib/castle/core/process_response.rb

@@ -9,10 +9,11 @@ module ProcessResponse
         401 => Castle::UnauthorizedError,
         403 => Castle::ForbiddenError,
         404 => Castle::NotFoundError,
-        419 => Castle::UserUnauthorizedError,
-        422 => Castle::InvalidParametersError
+        419 => Castle::UserUnauthorizedError
       }.freeze
 
+      INVALID_REQUEST_TOKEN = 'invalid_request_token'
+
       class << self
         # @param response [Response]
         # @param config [Castle::Configuration, Castle::SingletonConfiguration, nil]
@@ -36,8 +37,29 @@ def verify!(response)
 
           raise Castle::InternalServerError if response.code.to_i.between?(500, 599)
 
+          raise_error422(response) if response.code.to_i == 422
+
           error = RESPONSE_ERRORS.fetch(response.code.to_i, Castle::ApiError)
-          raise error, response[:message]
+
+          raise error
+        end
+
+        def raise_error422(response)
+          if response.body
+            begin
+              parsed_body = JSON.parse(response.body, symbolize_names: true)
+              if parsed_body.is_a?(Hash) && parsed_body.key?(:type)
+                if parsed_body[:type] == INVALID_REQUEST_TOKEN
+                  raise Castle::InvalidRequestTokenError, parsed_body[:message]
+                else
+                  raise Castle::InvalidParametersError, parsed_body[:message]
+                end
+              end
+            rescue JSON::ParserError
+            end
+          end
+
+          raise Castle::InvalidParametersError
         end
       end
     end

lib/castle/errors.rb

@@ -53,6 +53,10 @@ class UserUnauthorizedError < Castle::ApiError
   class InvalidParametersError < Castle::ApiError
   end
 
+  # api error invalid param 422 (invalid token)
+  class InvalidRequestTokenError < Castle::ApiError
+  end
+
   # api error unauthorized 401
   class UnauthorizedError < Castle::ApiError
   end

spec/lib/castle/client_spec.rb

@@ -41,13 +41,18 @@
   let(:time_auto) { time_now.utc.iso8601(3) }
   let(:time_user) { (Time.now - 10_000).utc.iso8601(3) }
   let(:response_body) { {}.to_json }
+  let(:response_code) { 200 }
+
+  let(:stub_response) do
+    stub_request(:any, /api.castle.io/)
+      .with(basic_auth: ['', 'secret'])
+      .to_return(status: response_code, body: response_body, headers: {})
+  end
 
   before do
     Timecop.freeze(time_now)
     stub_const('Castle::VERSION', '2.2.0')
-    stub_request(:any, /api.castle.io/)
-      .with(basic_auth: ['', 'secret'])
-      .to_return(status: 200, body: response_body, headers: {})
+    stub_response
   end
 
   after { Timecop.return }

spec/support/shared_examples/action_request.rb

@@ -152,4 +152,34 @@
       it { expect(request_response[:failover_reason]).to be_eql('Castle::InternalServerError') }
     end
   end
+
+  context 'when request is 422' do
+    describe 'throw InvalidParametersError' do
+      let(:response_body) { { type: 'bad_request', message: 'wrong params' }.to_json }
+      let(:response_code) { 422 }
+
+      it do
+        expect { request_response }.to raise_error(Castle::InvalidParametersError, 'wrong params')
+      end
+    end
+
+    describe 'throw InvalidParametersError for legacy endpoints' do
+      let(:response_body) { {}.to_json }
+      let(:response_code) { 422 }
+
+      it { expect { request_response }.to raise_error(Castle::InvalidParametersError) }
+    end
+
+    describe 'throw InvalidRequestTokenError' do
+      let(:response_body) { { type: 'invalid_request_token', message: 'invalid token' }.to_json }
+      let(:response_code) { 422 }
+
+      it do
+        expect { request_response }.to raise_error(
+          Castle::InvalidRequestTokenError,
+          'invalid token'
+        )
+      end
+    end
+  end
 end