Make sure record/verify/properties actually affect test tasks #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodbx
approved these changes
Jan 19, 2023
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
changed the title
TWiStErRob
force-pushed
the
rerunrecordverify
branch
from
e520362 to
b97eccb
Compare
|
Related Gradle feature: gradle/gradle#9092 |
|
Is there anything missing here @jrodbx? |
jrodbx
approved these changes
Mar 24, 2023
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
Comment on lines
168
to
177
| // Explicitly register these as inputs so that they are considered when determining up-to-date. | ||
| // The properties become resolvable after the last afterEvaluate runs. | ||
| test.inputs.property("paparazzi.test.record", isRecordRun) | ||
| test.inputs.property("paparazzi.test.verify", isVerifyRun) |
There was a problem hiding this comment.
style nit: can we move this under the other "inputs" (just after "paparazzi.nativePlatform")? also, let's remove the comment, since this is standard Gradle knowledge.
There was a problem hiding this comment.
I moved it together with the systemProperties, i.e. the first inputs, because they're an implementation detail of the missing inputs.property(name, provider) API.
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
...razzi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
…ify parameters are not playing in up to date checks and fix by registering inputs explicitly. Co-authored-by: John Rodriguez <[email protected]>
… builds. It's a standard HashMap not a DomainObjectCollection, so there won't be any further items inserted between filterKeys and doFirst.
TWiStErRob
force-pushed
the
rerunrecordverify
branch
from
b97eccb to
a232f86
Compare
|
Addressed all the comments in separate commits, when merging select squash merge please. |
TWiStErRob
force-pushed
the
rerunrecordverify
branch
2 times, most recently
from
44a7737 to
217a629
Compare
jrodbx
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #206 (comment)
Fixes #747