Merged
Conversation
* main: Payouts API: Create Request endpoint (#158)
pedronveloso
requested review from
KingsleyOkeke14,
drewhamilton,
frostyshadows and
kylemboos
Collaborator
|
I just merged #160, so you'll have to rebase this and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
There are several portions of the SDK that are currently public, but aren't meant to be accessible by consumers of the SDK. We want to cleanup these for the following advantages:
Better Encapsulation
- Internal utilities, extensions, and constants properly hidden
- Clear distinction between public contract and private implementation
Flexibility for Future Changes
- Internal APIs can be refactored without breaking SDK consumers
Improved Developer Experience
- Less visual clutter in IDE when using the SDK
- Clearer understanding of what's meant to be used vs. what's internal
How
Took a pass over the codebase searching for instances of code that could be refactored to internal. Among these were several Moshi adapters. Moshi generated code will preserve the access level of the adapter.
CustomerResponseDataremains public as well as its nested types. This is also enforced by the compiler.Proof
Since the Dev App exercises every single public aspect of the SDK, compiling and running it successfully is a fairly good test to verify that nothing was made internal that shouldn't have.
dev-app-monkey-testing.mp4