Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship a single
all:bottle for the formulae that contain no compiled code.cartesi-machine-linux-image,cartesi-machine-rootfs-imageandcartesi-machineinstall byte-identical content on every platform — two downloaded images plus a symlink, and an empty marker file for the metapackage — yet each was getting its own per-OS bottle. For the rootfs image that means re-tarring a large ext2 on every runner to produce the same artifact twice.brew bottle --mergecollapses tags into a singleall:bottle only when every tag's tarball has the same cellar and sha256. That never happens by default, because the install receipt embedded in the tarball carries per-platform data —brew's own comment indev-cmd/bottle.rbis "Without--only-json-tabbottles are never reproducible". Passing--only-json-tabwrites the receipt to the bottle JSON (and on to the ghcr metadata) instead of into the tarball, which makes the tarballs reproducible across runners.Changes:
.github/workflows/tests.yml: add--only-json-tabto thebrew test-bot --only-formulaestep.revision, sobrew pr-pullwrites fresh ones.Expected result after
pr-pull: the three formulae above each get onesha256 cellar: :any_skip_relocation, all: "..."line.cartesi-machine-emulatoris the only formula here that actually compiles, so it keeps its per-tag bottles (arm64_sequoia,arm64_tahoe).Two notes for review:
bottling: true, which drops runtime-dependency URLs/checksums and compiler info, socartesi-machinehaving dependencies does not make its tarball platform-specific.cartesi-machinehas anall:bottle,brew test-bottreats it as bottled only on runners where all three of its dependencies are bottled (bottled?recurses into deps for:allbottles). That is satisfied on the current arm64-only matrix.🤖 Generated with Claude Code