-
Notifications
You must be signed in to change notification settings - Fork 12
Remove cannon from devnet build #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e34daba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e9f41d8 to
5f63dcb
Compare
|
This still must be improved quite a bit. I think the content of the devnet package must be the same as it is now, a state dump and deployment files, one for each contract, with at least If we don't do that it will complicate the cli side, which uses wagmi to process deployment information. |
5f63dcb to
30a7fc9
Compare
|
If I run with the wrong anvil version, the script fails to start anvil but keeps trying, and doesn't say that the problem is the version. After installing the correct 1.4.3 version, I get this error: |
For some reason, there was an existing anvil process running and that was the issue. After killing all anvil processes, I manage to run the build successfully. |
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cartesi/devnet build works
BUT @cartesi/cli is failling
@cartesi/cli:build: $ bun build.ts
@cartesi/cli:build: 2 | daveAppFactoryAddress,
@cartesi/cli:build: ^
@cartesi/cli:build: error: No matching export in "src/contracts.ts" for import "daveAppFactoryAddress"
@cartesi/cli:build: at /home/endersonmaia/Work/cartesi/cli/apps/cli/src/compose/node.ts:2:5
@cartesi/cli:build:
@cartesi/cli:build: 3 | inputBoxAddress,
@cartesi/cli:build: ^
@cartesi/cli:build: error: No matching export in "src/contracts.ts" for import "inputBoxAddress"
@cartesi/cli:build: at /home/endersonmaia/Work/cartesi/cli/apps/cli/src/compose/node.ts:3:5
@cartesi/cli:build:
@cartesi/cli:build: 4 | selfHostedApplicationFactoryAddress,
@cartesi/cli:build: ^
@cartesi/cli:build: error: No matching export in "src/contracts.ts" for import "selfHostedApplicationFactoryAddress"
@cartesi/cli:build: at /home/endersonmaia/Work/cartesi/cli/apps/cli/src/compose/node.ts:4:5
@cartesi/cli:build:
@cartesi/cli:build: Bun v1.3.5 (Linux x64)
@cartesi/cli:build: error: script "compile" exited with code 1
@cartesi/cli:build: ERROR: "compile" exited with 1.
@cartesi/cli:build: error: script "build" exited with code 1
@cartesi/cli:build: ERROR: command finished with error: command (/home/endersonmaia/Work/cartesi/cli/apps/cli) /usr/bin/bun run build exited (1)
@cartesi/cli#build: command (/home/endersonmaia/Work/cartesi/cli/apps/cli) /usr/bin/bun run build exited (1)
I'm assuming that this will be solved on another PR.
Yes, the CLI will need a small change to work. I have it ready to commit. It is strange that the cli is resolving the dependency of "2.0.0-alpha.8" to the workspace project instead of the published version. Because it is not marked as "workspace:*". |
Maybe Bun workspaces works a little differente from turbo's. |
Coverage Report for ./apps/cli
File CoverageNo changed files found. |
This PR removes cannon from devnet build process.
Now it downloads cartesi anvil state from GitHub release, deploy devnet contracts (tokens), and dump a new state.