Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Correct variable used in install tests #1977

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mjpieters
Copy link
Contributor

@mjpieters mjpieters commented Nov 20, 2024

The STRIP_V env var should be set from the set_binstall_version matrix variable.

While here, ensure that the install-script workflow is run whenever the workflow itself is changed (in addition to the install scripts themselves).

@mjpieters
Copy link
Contributor Author

This time, I verified the workflow by running it in my fork first. 🤦

The `STRIP_V` env var should be set from the `set_binstall_version`
matrix variable.

While here, ensure that the install-script workflow is run whenever
the workflow itself is changed (in addition to the install scripts
themselves).
@mjpieters mjpieters force-pushed the correct-workflow-variable branch from ff4533b to 46b29f6 Compare November 20, 2024 09:58
Copy link
Member

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu added this pull request to the merge queue Nov 20, 2024
Merged via the queue into cargo-bins:main with commit dabb630 Nov 20, 2024
46 checks passed
@mjpieters mjpieters deleted the correct-workflow-variable branch November 20, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants