Disable zlib-ng for aarch64 linux and re-enable it for x64 linux #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
|
Sorry for requesting your review again @passcod since #1564 can't work due to the unknown The only way forward is to disable zlib-ng on aarch64 linux, though I re-enable it on x86_64 linux to get back some performance on widely used targets, though I'm not sure if it will work and I might have to revert that decision later. |
passcod
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the error in #1563 CI and also re-enable zlib-ng for x86_64 linux to improve its performance since it is one of the most used targets.