refactor: operations parsing refak #649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
force-pushed
the
operations-parsing-refak
branch
from
d43ec40 to
1fcd95f
Compare
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
matiwinnetou
force-pushed
the
operations-parsing-refak
branch
2 times, most recently
from
6c73dba to
f02b569
Compare
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
matiwinnetou
force-pushed
the
operations-parsing-refak
branch
from
f02b569 to
83ad587
Compare
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
1 similar comment
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
matiwinnetou
force-pushed
the
operations-parsing-refak
branch
from
83ad587 to
6b2f28a
Compare
added 2 commits
November 14, 2025 14:24
Remove duplicate dRepVoteDelegation operations from integration test golden files. These duplicates were appearing due to the certificate processing logic creating operations twice. This fix aligns with the TransactionOperationParser refactoring that properly handles DRep vote delegation certificates.
matiwinnetou
force-pushed
the
operations-parsing-refak
branch
from
6b2f28a to
45c05cd
Compare
invariants Fixed 4 failing /construction/parse golden tests that had duplicate operations at index 3. Tests expected 5 operations but API correctly returned 4. Added operation invariant tests to prevent ordering bugs: - assert_operations_ordered() - ensures operations sorted by index - assert_operations_sequential() - ensures indices [0, 1, 2, ...] Covers /search/transactions, /block, and /block/transaction endpoints. This would have caught the bug where /construction/parse returns operations in processing order (inputs → outputs → certs → withdrawals) instead of sorted by operation_identifier.index.
Member
|
I fixed the other failing tests but found a small issue with the The API is returning operations in the order they were processed (inputs → outputs → certs → withdrawals), but the test expects them sorted by their uv run tests/integration/test_construction_api.py -u http://localhost:8082 "parse/complex_transactions/withdrawal_with_drep_delegation.json"Expected: Array ordered by index [0, 1, 2, 3] {
"operations": [
{ "operation_identifier": { "index": 0 }, "type": "input", ... },
{ "operation_identifier": { "index": 1 }, "type": "output", ... },
{ "operation_identifier": { "index": 2 }, "type": "withdrawal", "amount": {...}, ... },
{ "operation_identifier": { "index": 3 }, "type": "dRepVoteDelegation", ... }
]
}Actual: Array ordered [0, 1, 3, 2] {
"operations": [
{ "operation_identifier": { "index": 0 }, "type": "input", ... },
{ "operation_identifier": { "index": 1 }, "type": "output", ... },
{ "operation_identifier": { "index": 3 }, "type": "dRepVoteDelegation", ... },
{ "operation_identifier": { "index": 2 }, "type": "withdrawal", "amount": {...}, ... }
]
}The test fails because it accesses We just need to sort the operations list by index before returning it. |
- Sort operations by operation_identifier.index before returning from getOperationsFromTransactionData() to ensure consistent ordering (0, 1, 2, ...) - Add OperationOrdering test class with shouldReturnOperationsSortedByIndex test to verify sorting behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.