feat(AddSelect): add dynamic additional component at start of body #5438
Conversation
glapadre
requested review from
ariellalgilmore and
IgnacioBecerra
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@glapadre thanks for providing this! Two things;
one minor code comment: can we switch additionalInfo to supplementalHeader? i think that helps convey what the prop does.
i know theres a greater discussion at hand about the add/select structure, so i don't think this needs a whole DSAG intervention, but could you find a designer associated with add/select to sign off on this? i think the story could look a little nicer and better describe what the feature is. working with someone on the design side just to establish like a minimal requirement for this part of the pattern would be great.
if you have any questions holler at me!
|
@davidmenendez no problem! I started a thread in the issue related to naming convention but it didn't get any traction, |
|
@glapadre awesome! thanks. keep me up to date 👍 |
|
@davidmenendez I have shared with Oliver Kauselmann (designer that worked on add/select) and he said he will take a look and share here |
|
@glapadre awesome! thanks a bunch |
davidmenendez
added
the
needs: design opinion
|
Had a call with Marion H. and Oliver K. and we are working on updating the guidance on the PAL design site, once this is complete Marion and Oliver gave the green light to merge. |
|
@glapadre any update on this? |
Closes #5252
Add custom component option at the beginning of the Body (in our case we are using TextInput but it could be anything here.
What did you change?
packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snappackages/ibm-products-styles/src/components/AddSelect/_add-select.scsspackages/ibm-products/src/components/AddSelect/AddSelect.tsxpackages/ibm-products/src/components/AddSelect/AddSelectBody.test.jspackages/ibm-products/src/components/AddSelect/AddSelectBody.tsxpackages/ibm-products/src/components/MultiAddSelect/MultiAddSelect.stories.jsxpackages/ibm-products/src/components/MultiAddSelect/MultiAddSelect.tsxpackages/ibm-products/src/components/SingleAddSelect/SingleAddSelect.stories.jsxpackages/ibm-products/src/components/SingleAddSelect/SingleAddSelect.tsxHow did you test and verify your work?
Storybook