Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added href to iconButton #18283

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

riddhybansal
Copy link
Contributor

Closes #17955

Added href to iconButton

Changelog

New

-Added href to iconButton

Testing / Reviewing

Try using IconButton in .tsx file it should work as intended and should not show any typescript error.

@riddhybansal riddhybansal requested a review from a team as a code owner December 27, 2024 19:10
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 75b6913
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6777fe5c7158020007de57af
😎 Deploy Preview https://deploy-preview-18283--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 75b6913
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6777fe5c3331be000811c27b
😎 Deploy Preview https://deploy-preview-18283--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 You just have to run yarn test -u to update the snapshots.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 75b6913
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6777fe5c6cfcc60008eda935
😎 Deploy Preview https://deploy-preview-18283--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riddhybansal riddhybansal requested a review from a team as a code owner January 2, 2025 14:32
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (97fc2e6) to head (75b6913).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18283   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files         406      406           
  Lines       14407    14407           
  Branches     4686     4636   -50     
=======================================
  Hits        12124    12124           
- Misses       2118     2119    +1     
+ Partials      165      164    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2nikhiltom 2nikhiltom enabled auto-merge January 3, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IconButton types do not include href
5 participants