Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update focus states for Dropdown, Combobox & Multiselect #18230

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 9, 2024

Closes #18071

Update focus states depending on if there are selected items and if user clicks/enters or presses arrow down for the following components:

  • Dropdown
  • Fluid Dropdown
  • ComboBox
  • Fluid ComboBox
  • Multiselect
  • Fluid MultiSelect
  • Filterable Multiselect
  • Select all

Following this figma kit

Changelog

Changed

  • adjust focus styles
  • add focus classnames

Removed

  • console.log

Testing / Reviewing

Go to deploy preview check the click/enter/arrow-down interactions for the above mentioned components and make sure it follows this figma kit

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 63fa9da
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6761d577bc98300008c65b3b
😎 Deploy Preview https://deploy-preview-18230--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 63fa9da
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6761d5777d496c00088f225c
😎 Deploy Preview https://deploy-preview-18230--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 63fa9da
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6761d5777d496c00088f225e
😎 Deploy Preview https://deploy-preview-18230--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (1cf7200) to head (63fa9da).

Files with missing lines Patch % Lines
...ackages/react/src/components/Dropdown/Dropdown.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18230   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         404      404           
  Lines       14359    14368    +9     
  Branches     4656     4610   -46     
=======================================
+ Hits        12107    12115    +8     
- Misses       2090     2091    +1     
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 marked this pull request as ready for review December 17, 2024 19:48
@annawen1 annawen1 requested a review from a team as a code owner December 17, 2024 19:48
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @annawen1,
Thank you for working on this! I have a few small points I wanted to share and discuss. Please let me know if you'd prefer to connect over a call to go over these in more detail:

Fluid Dropdown

There seems to be a bug where the focus stroke doesn’t reappear after using the down arrow key.

Screen Recording 2024-12-26 at 7 13 56 PM

Combo box & Multiselect

  1. Just wanted to crosscheck if the focus stroke is 2px in situations like these:

image

  1. Is the focus state supposed to move dynamically with the cursor, similar to the dropdown?

Screen Recording 2024-12-24 at 2 53 52 PM
Screen Recording 2024-12-24 at 2 53 06 PM

  1. For both fluid and default filterable multi-select and filterable with layer multi-select, the down arrow key doesn’t appear to function as expected.
image
  1. In fluid filterable and filterable with layer multi-select, the tab and enter key interactions don’t align with what’s specified in the Figma kit:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update Dropdown, Combobox & Multiselect focus states
3 participants