-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update focus states for Dropdown, Combobox & Multiselect #18230
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18230 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 404 404
Lines 14359 14368 +9
Branches 4656 4610 -46
=======================================
+ Hits 12107 12115 +8
- Misses 2090 2091 +1
Partials 162 162 ☔ View full report in Codecov by Sentry. |
… into chore/focus-states
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @annawen1,
Thank you for working on this! I have a few small points I wanted to share and discuss. Please let me know if you'd prefer to connect over a call to go over these in more detail:
Fluid Dropdown
There seems to be a bug where the focus stroke doesn’t reappear after using the down arrow key.
Combo box & Multiselect
- Just wanted to crosscheck if the focus stroke is 2px in situations like these:
- Is the focus state supposed to move dynamically with the cursor, similar to the dropdown?
- For both fluid and default filterable multi-select and filterable with layer multi-select, the down arrow key doesn’t appear to function as expected.
- In fluid filterable and filterable with layer multi-select, the tab and enter key interactions don’t align with what’s specified in the Figma kit:
Closes #18071
Update focus states depending on if there are selected items and if user clicks/enters or presses arrow down for the following components:
Following this figma kit
Changelog
Changed
Removed
Testing / Reviewing
Go to deploy preview check the click/enter/arrow-down interactions for the above mentioned components and make sure it follows this figma kit