chore: allow(unsafe_code) in generated code #610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capnpc-ruststarts generating code withunsafeblock after #607. Therefore, add#[allow(unsafe_code)]to avoid warnings or errors as much as possible.However, IMHO, introducing
unsafeblock to generated code might be an obstacle for projects using#![forbid(unsafe_code)]to guarantee the use of safe Rust only. Some of the projects will need to relax their guarantee to be able to use capnproto-rust, like https://github.com/o1-labs/mina-network-debugger/blob/main/mina-ipc/src/lib.rs.Additionally, I'm not sure about whether adding these
#![allow]to the top of the generated file is a better idea, so I chose to follow the existing one.P.S., Actually, we already have a
#![allow]in generated file:capnproto-rust/capnpc/src/codegen.rs
Line 2555 in 9c1058b
^ I'm more than happy to move
#![allow]to generated file if this is suitable.