-
Notifications
You must be signed in to change notification settings - Fork 247
RFC/WIP: Introduce capnp-json for JSON code compatible with c++ default capnproto implementation #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 51.64% 51.51% -0.13%
==========================================
Files 69 77 +8
Lines 33735 35258 +1523
==========================================
+ Hits 17422 18163 +741
- Misses 16313 17095 +782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
190c1f6 to
a3d6558
Compare
| field_meta.name | ||
| ))); | ||
| }; | ||
| Ok((*field_value as i8).into()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle encoded values > 127 correctly.
ditto for the other types, we should fail, rather than panic.
| JsonValue::String(field_value) => { | ||
| let enum_schema = capnp::schema::EnumSchema::new(enum_schema); | ||
| let Some(enum_value) = enum_schema.get_enumerants()?.iter().find(|e| { | ||
| // FIXME: this is naive, enum values can be renamed using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment, it's handled
We simply write synchronously to a std::io::Write. The codec supports all types that the C++ codec supports, along with the flatten, hex and base64 annotations. It does not support discriminated unions yet. It supports only encode, no decode. It's not fast, efficient, or especially good.
…t schema from c++ repo
…bility with the c++ implementation... and fix the resulting bugs found
…rs with a discriminator
2cea57f to
de66bbc
Compare
As discussed in #68, I'm sharing this very rough cut of JSON codec support for input.
Some assumptions I made, which influenced the implementation, but could be changed depending on your view:
What's supported:
flatten,discriminator,namebase64,hexandarray of numbersencodings forDatafields.The best doc on the actual encoding is the json.capnp which is taken directly from upstream. We don't use all of it, but I kept it unmodified anyway.
What's not supported, and what deviates from the upstream implementation: