-
Couldn't load subscription status.
- Fork 242
capnpc: add option to build capnp exe from src
#268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "capnpc/capnproto"] | ||
| path = capnpc/capnproto | ||
| url = https://github.com/capnproto/capnproto.git |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #[cfg(feature = "build-capnp")] | ||
| fn main() { | ||
| cmake::build("capnproto"); | ||
| } | ||
|
|
||
| #[cfg(not(feature = "build-capnp"))] | ||
| fn main() { | ||
| if !which::which("capnp").is_ok() { | ||
| panic!( | ||
| "capnp executable not found. install it with your package manager or enable the \ | ||
| \"build-capnp\" feature to build it from source" | ||
| ); | ||
| } | ||
|
Comment on lines
+8
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if !which::which("capnp").is_ok() {
panic!(msg);
}could be written as: which::which("capnp").expect(msg); |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,6 +66,19 @@ mod pointer_constants; | |
|
|
||
| use std::path::{Path, PathBuf}; | ||
|
|
||
| #[cfg(feature = "build-capnp")] | ||
| fn capnp_exe() -> PathBuf { | ||
| let mut p = PathBuf::from(env!("OUT_DIR")); | ||
| p.push("bin"); | ||
| p.push("capnp"); | ||
| p | ||
|
Comment on lines
+71
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably a matter of style, but you could just use: PathBuf::from(env!("OUT_DIR"))
.join("bin")
.join("capnp") |
||
| } | ||
|
|
||
| #[cfg(not(feature = "build-capnp"))] | ||
| fn capnp_exe() -> PathBuf { | ||
| PathBuf::from("capnp") | ||
| } | ||
|
|
||
| // Copied from capnp/src/lib.rs, where this conversion lives behind the "std" feature flag, | ||
| // which we don't want to depend on here. | ||
| pub(crate) fn convert_io_err(err: std::io::Error) -> capnp::Error { | ||
|
|
@@ -218,7 +231,7 @@ impl CompilerCommand { | |
| let mut command = if let Some(executable) = &self.executable_path { | ||
| ::std::process::Command::new(executable) | ||
| } else { | ||
| ::std::process::Command::new("capnp") | ||
| ::std::process::Command::new(&capnp_exe()) | ||
| }; | ||
|
|
||
| command.arg("compile").arg("-o").arg("-"); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmakeshould probably be marked optional, while activated bybuild-capnpfeature?See also Cargo reference. The
dep:syntax requires Rust 1.60.