fix comments

capitalone · Apr 24, 2024 · a25a997 · a25a997
1 parent 0751d86
commit a25a997
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/dataprofiler/profilers/categorical_column_profile.py b/dataprofiler/profilers/categorical_column_profile.py
@@ -682,7 +682,7 @@ def update(self, df_series: Series) -> CategoricalColumn:
         :rtype: CategoricalColumn
         """
         # TODO remove onces profiler builder is updated
-        if type(df_series) == pd.Series:
+        if isinstance(df_series, pd.Series):
             df_series = pl.from_pandas(df_series)  # type: ignore
         # If condition for limiting profile calculations
         if len(df_series) == 0 or self._stop_condition_is_met:

diff --git a/dataprofiler/tests/profilers/test_categorical_column_profile.py b/dataprofiler/tests/profilers/test_categorical_column_profile.py
@@ -20,8 +20,6 @@
 
 
 class TestCategoricalColumn(unittest.TestCase):
-    maxDiff = None
-
     @classmethod
     def setUp(self):
         test_utils.set_seed(seed=0)
@@ -889,7 +887,6 @@ def test_json_encode(self):
 
     def test_json_encode_after_update(self):
         df_categorical = pl.Series(
-            None,
             [
                 "a",
                 "a",