Skip to content

Conversation

@xoapit
Copy link

@xoapit xoapit commented Oct 23, 2025

What?

Gets correct widget ref from the document to remove the corresponding annotation ref from the page

Why?

Trying to fix this issue: Hopding#1267
Original discussion: Hopding#1268

How?

Gets the ref using doc.context.getObjectRef instead of findWidgetAppearanceRef (which seems to get the wrong ref?)

Testing?

Ran the unit tests

New Dependencies?

N/A

Screenshots

N/A

Suggested Reading?

N/A

Anything Else?

N/A

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

@Sharcoux Sharcoux merged commit a716f37 into cantoo-scribe:master Oct 31, 2025
1 check passed
@Sharcoux
Copy link
Collaborator

Thanks a lot! Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants