feat: partitions always enabled - #6397
Draft
cmatsuoka wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes Snapcraft’s dependency resolution to use a git branch of craft-parts (to get “partitions always enabled”) instead of consuming a released craft-parts version from PyPI.
Changes:
- Switched
craft-partsfrom a version constraint (>=2.33.0) to a VCS dependency oncmatsuoka/craft-parts@feat/partitions-always-enabledinpyproject.toml. - Updated
uv.lockto lockcraft-partsfrom that git source (and adjusted lock metadata accordingly).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Locks craft-parts to a git source/commit and updates dependency metadata to reflect the VCS dependency. |
| pyproject.toml | Replaces the released craft-parts requirement with a git-based dependency pointing at a feature branch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+13
to
+14
| #"craft-parts>=2.33.0", | ||
| "craft-parts@git+https://github.com/cmatsuoka/craft-parts@feat/partitions-always-enabled", |
cmatsuoka
added
the
PR: Run Manual Spread
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
experimental/partitions-always-enabled
branch
from
August 20, 2026 23:06
be836f3 to
64533b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes.
make lint && make test.