[DPE-8816] Remove workaround for juju#21047 #1165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (65.80%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1165 +/- ##
========================================
Coverage 65.80% 65.80%
========================================
Files 18 18
Lines 4068 4068
Branches 600 600
========================================
Hits 2677 2677
Misses 1189 1189
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…remove-workaround Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
requested review from
a team,
dragomirp,
onkolahmet and
taurus-forever
and removed request for
a team
…rkaround Signed-off-by: Marcelo Henrique Neppel <[email protected]>
github-actions
bot
added
Libraries: OK
taurus-forever
approved these changes
Dec 2, 2025
onkolahmet
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We added some workaround in #1154 to make the CI work while we waited for a fix in Juju secrets (which landed in Juju 3.6.12).
Solution
Remove the workaround (with Juju 3.6.12, it's possible to again deploy the charm in the same model with the same name).
Checklist