generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 5
Add refresh v3 implementation #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlcsaposs-canonical
wants to merge
29
commits into
main
Choose a base branch
from
refresh-v3-draft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6abcf4f
Add refresh v3 draft implementation
carlcsaposs-canonical 5b72ce3
Simplify reconcile
carlcsaposs-canonical 8399f67
Add `self._reconcile_allowed` instead of exiting
carlcsaposs-canonical bbc4cff
Sync with K8s
carlcsaposs-canonical 25755c6
Remove workload version set
carlcsaposs-canonical b843d69
Include logger name in logs
carlcsaposs-canonical 2bca452
Update charm-refresh
carlcsaposs-canonical 654e049
Update charm_refresh
carlcsaposs-canonical 25ef8fb
Use JSON schema
carlcsaposs-canonical 4a0ded3
Use released charm-refresh
carlcsaposs-canonical da2fd87
Update comment
carlcsaposs-canonical 0096070
Check workload version
carlcsaposs-canonical f6e3fac
Update data-platform-workflows to v32.0.0
carlcsaposs-canonical a9a895e
Set charm refresh compatibility version from git tag
carlcsaposs-canonical 53598ba
Format
carlcsaposs-canonical 6db28d2
Revert (for testing) "Set charm refresh compatibility version from gi…
carlcsaposs-canonical a92f321
Fix unit test mocks
carlcsaposs-canonical 3f004cb
Format
carlcsaposs-canonical fae5951
Increase numprocesses to workaround memory leak
carlcsaposs-canonical 34634b5
Increase numprocesses to workaround memory leak
carlcsaposs-canonical d0dda6a
Set charm refresh compatibility version from git tag
carlcsaposs-canonical c94991e
Revert (for testing) "Set charm refresh compatibility version from gi…
carlcsaposs-canonical b512ca5
Revert testing changes
sinclert-canonical ebce78a
Fix unit tests
sinclert-canonical a03211f
Fix unit tests [alternative]
sinclert-canonical faf1dda
Fix integration tests
sinclert-canonical 61b16a8
[Temp] Disable charmcraft version build
sinclert-canonical 76505d4
[Temp] Hard-code charm version
sinclert-canonical 86fceca
[Temp] Point to a refresh v3 channel
sinclert-canonical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Copyright 2023 Canonical Ltd. | ||
# See LICENSE file for licensing details. | ||
name: Release to Charmhub | ||
name: Release to Charmhub edge | ||
|
||
on: | ||
push: | ||
|
@@ -13,8 +13,18 @@ on: | |
- '.github/workflows/sync_docs.yaml' | ||
|
||
jobs: | ||
tag: | ||
name: Create charm refresh compatibility version git tag | ||
uses: canonical/data-platform-workflows/.github/workflows/[email protected] | ||
with: | ||
track: 'dpe' | ||
permissions: | ||
contents: write # Needed to create git tag | ||
|
||
ci-tests: | ||
name: Tests | ||
needs: | ||
- tag | ||
uses: ./.github/workflows/ci.yaml | ||
secrets: inherit | ||
permissions: | ||
|
@@ -23,10 +33,11 @@ jobs: | |
release: | ||
name: Release charm | ||
needs: | ||
- tag | ||
- ci-tests | ||
uses: canonical/data-platform-workflows/.github/workflows/release_charm.yaml@v31.0.1 | ||
uses: canonical/data-platform-workflows/.github/workflows/release_charm_edge.yaml@v32.0.0 | ||
with: | ||
channel: dpe/edge | ||
track: ${{ needs.tag.outputs.track }} | ||
artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }} | ||
secrets: | ||
charmhub-token: ${{ secrets.CHARMHUB_TOKEN }} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,14 @@ | |
# See LICENSE file for licensing details. | ||
|
||
options: | ||
|
||
vip: | ||
description: | | ||
Virtual IP to use to front mysql router units. Used only in case of external node connection. | ||
type: string | ||
pause_after_unit_refresh: | ||
description: | | ||
Wait for manual confirmation to resume refresh after these units refresh | ||
|
||
Allowed values: "all", "first", "none" | ||
type: string | ||
default: first | ||
Comment on lines
+9
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Finally! THANK YOU! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be applied before merge