Merged
Conversation
2ea84bb to
f2dee5e
Compare
f2dee5e to
36fedb1
Compare
shayancanonical
approved these changes
Apr 24, 2025
carlcsaposs-canonical
requested changes
Apr 24, 2025
Contributor
carlcsaposs-canonical
left a comment
There was a problem hiding this comment.
I think we should avoid touching this until we add support for 24.04
and at that point, I think we should be using https://pypi.org/project/charmlibs-pathops/ instead of a workaround
Author
|
Summary from online meeting:
|
paulomach
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Python 3.12 compatibility after the pathlib.Path family of classes changed in order to tweak how they behave when they are are extended via sub-classes.
References
Additional changes
data-integratorcharm base to fix integration tests