Skip to content

[MISC] Fix Python 3.12 compatibility#428

Merged
paulomach merged 3 commits intomainfrom
sinclert/python-3.12-compatibility
Apr 30, 2025
Merged

[MISC] Fix Python 3.12 compatibility#428
paulomach merged 3 commits intomainfrom
sinclert/python-3.12-compatibility

Conversation

@sinclert-canonical
Copy link
Copy Markdown

@sinclert-canonical sinclert-canonical commented Apr 23, 2025

This PR fixes Python 3.12 compatibility after the pathlib.Path family of classes changed in order to tweak how they behave when they are are extended via sub-classes.

References

Additional changes

  • Update data-integrator charm base to fix integration tests

@sinclert-canonical sinclert-canonical added the bug Something isn't working as expected label Apr 23, 2025
@github-actions github-actions Bot added the Libraries: Out of sync The charm libs used are out-of-sync label Apr 23, 2025
Comment thread src/rock.py Outdated
@sinclert-canonical sinclert-canonical force-pushed the sinclert/python-3.12-compatibility branch from 2ea84bb to f2dee5e Compare April 24, 2025 08:39
@sinclert-canonical sinclert-canonical force-pushed the sinclert/python-3.12-compatibility branch from f2dee5e to 36fedb1 Compare April 24, 2025 10:36
@sinclert-canonical sinclert-canonical marked this pull request as ready for review April 24, 2025 11:12
Copy link
Copy Markdown
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid touching this until we add support for 24.04

and at that point, I think we should be using https://pypi.org/project/charmlibs-pathops/ instead of a workaround

@sinclert-canonical
Copy link
Copy Markdown
Author

Summary from online meeting:

  • @carlcsaposs-canonical is worried that these changes are not enough to get the support ubuntu@24.04 base. Further validation is needed.
  • For local set-ups, there is nothing stopping folks to run code / tests using Python 3.12+, as denoted by this line within the pyproject.toml file. We should change that to make it clear that Python 3.12+ is unsupported.

@paulomach paulomach merged commit 69aa17f into main Apr 30, 2025
33 checks passed
@paulomach paulomach deleted the sinclert/python-3.12-compatibility branch April 30, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants