Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log in before displaying 404 for some routes #1834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huwshimi
Copy link
Contributor

Done

  • Don't display the 404 page for some routes until after login.

QA

  • Connect your dashboard to JAAS.
  • Log out.
  • Go to /permissions.
  • It should ask you to log in.

Details

https://warthogs.atlassian.net/browse/WD-18219

@webteam-app
Copy link

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (86c9ed0) to head (09aaa18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1834   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         426      426           
  Lines       16314    16323    +9     
  Branches     2955     2957    +2     
=======================================
+ Hits        15910    15919    +9     
  Misses        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants