Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ReBAC Admin feature branch #1830

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Jan 9, 2025

Done

  • Merge rebac-admin feature branch into main.
  • Fix imports due to deps changes (16b0705 - these are the only changes that weren't in the feature branch).

Details

https://warthogs.atlassian.net/browse/WD-18036

@webteam-app
Copy link

@huwshimi huwshimi changed the title Ra merge main Merge ReBAC Admin feature branch Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 97.17742% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (7f1bd9c) to head (16b0705).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/components/SecondaryNavigation/types.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   97.45%   97.52%   +0.06%     
==========================================
  Files         417      426       +9     
  Lines       16147    16314     +167     
  Branches     2928     2955      +27     
==========================================
+ Hits        15736    15910     +174     
+ Misses        411      404       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@M7mdisk M7mdisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huwshimi huwshimi merged commit 86c9ed0 into canonical:main Jan 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants