Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add transaction to flow persistence #26

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: add transaction to flow persistence #26

merged 3 commits into from
Aug 1, 2024

Conversation

nsklikas
Copy link

Wrap the flow persistence and user_code invalidation in a transaction. This does not full solve the issue with having multiple flows persisted per user_code as need to fix #25 first.

@nsklikas nsklikas requested a review from a team as a code owner July 30, 2024 13:37
@nsklikas nsklikas changed the title Add transaction to flow persistence fix: add transaction to flow persistence Jul 30, 2024
shipperizer
shipperizer previously approved these changes Jul 31, 2024
View reviewed changes
wood-push-melon
wood-push-melon previously approved these changes Aug 1, 2024
View reviewed changes
Copy link

@wood-push-melon wood-push-melon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just one minor NONBLOCKING thing: I found the comments a bit unclear:

https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1229
https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1237

It would be nice to make them more clear.

@nsklikas
Copy link
Author

nsklikas commented Aug 1, 2024

Just one minor NONBLOCKING thing: I found the comments a bit unclear:

https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1229 https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1237

It would be nice to make them more clear.

These comments come from the upstream code, I will try to

@nsklikas nsklikas dismissed stale reviews from wood-push-melon and shipperizer via 0b22d83 August 1, 2024 07:01
@nsklikas nsklikas enabled auto-merge August 1, 2024 07:01
@nsklikas nsklikas merged commit 327febe into canonical Aug 1, 2024
17 checks passed
@nsklikas nsklikas deleted the IAM-936 branch August 1, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipperizer shipperizer shipperizer approved these changes

@wood-push-melon wood-push-melon wood-push-melon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix update behavior
3 participants
@nsklikas @shipperizer @wood-push-melon