Skip to content

update openstack provider resources to v1beta1 - #125

Merged
rapour merged 4 commits into
mainfrom
KU-3872/update-openstack-templates
Aug 14, 2025
Merged

update openstack provider resources to v1beta1#125
rapour merged 4 commits into
mainfrom
KU-3872/update-openstack-templates

Conversation

@rapour

@rapour rapour commented Aug 11, 2025

Copy link
Copy Markdown

Changes the openstack provider API to v1beta1

  • The identityRef.Kind field has been removed. It was used to specify the kind of the identity provider to use but was actually ignored. The referenced resource must always be a Secret.
  • The cloudName field has been removed from both OpenStackMachine and OpenStackCluster and added to identityRef. It is now a required field when identityRef is specified.
  • In v1beta1, OpenStackCluster.Spec.ManagedSubnets array field is introduced. The NodeCIDR and DNSNameservers fields of OpenStackCluster.Spec are moved into that structure (renaming NodeCIDR to CIDR)
  • The field externalNetworkID has been renamed to externalNetwork and is now a NetworkParam object rather than a string ID.
  • It is now possible for a user to specify that no external network should be used by setting DisableExternalNetwork to true

rapour added 3 commits August 11, 2025 19:16
Signed-off-by: rapour <reza.abbasalipour@canonical.com>
Signed-off-by: rapour <reza.abbasalipour@canonical.com>
Signed-off-by: rapour <reza.abbasalipour@canonical.com>
@rapour
rapour marked this pull request as ready for review August 12, 2025 07:48

@berkayoz berkayoz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have we performed a test deployment with the template?

…ting

Signed-off-by: rapour <reza.abbasalipour@canonical.com>
@rapour

rapour commented Aug 14, 2025

Copy link
Copy Markdown
Author

Yes, but I removed the new disabled external network option to avoid conditional rendering of the template. The clusterctl generate cluster doesn't support Go style templates.

@rapour
rapour merged commit 48833fd into main Aug 14, 2025
5 checks passed
@rapour
rapour deleted the KU-3872/update-openstack-templates branch August 14, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants