fix(coding-agent): hide plugin skills from slash commands#2651
Merged
Conversation
Removed Claude marketplace plugin skill mirroring from slash-command discovery while keeping real plugin commands registered.\n\nFixes #2645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
A Claude marketplace plugin with
skills/understand/SKILL.mdwas loaded as both a skill and a bare slash command. Reproduced withbun test packages/coding-agent/test/discovery/claude-plugins.test.ts --test-name-pattern "exposes plugin skills as bare slash commands", which passed on the old code because/understandexpanded to the skill body.Cause
packages/coding-agent/src/discovery/claude-plugins.tscalledloadSkillSlashCommands()fromloadSlashCommands(), scanning each pluginskills/directory and appending those skills to the slash-command capability in addition to the normal skill provider.Fix
commands/slash-commandsdirectory loading unchanged.packages/coding-agent/test/discovery/claude-plugins.test.tsto assert plugin skills remain loadable as skills but absent from slash commands, while command manifest entries still load.Verification
bun test packages/coding-agent/test/discovery/claude-plugins.test.ts --test-name-pattern "keeps plugin skills out of slash commands|reads slash commands directory from plugin manifest commands field|reads slash commands directory from plugin manifest slash-commands field"passed.bun test packages/coding-agent/test/discovery/claude-plugins.test.tspassed. Fixes #2645