fix(coding-agent): respect startup.quiet for startup statuses#2640
Merged
Conversation
- Suppressed MCP connecting and LSP startup event renders when startup.quiet is enabled.\n- Added regression coverage for quiet MCP and LSP startup event handling.\n\nFixes #2639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
With
startup.quiet=true, emittingmcp:connectingstill reachedInteractiveMode.showStatus, and emitting a failedlsp:startupevent still reachedInteractiveMode.showWarning. I reproduced this withcd packages/coding-agent && bun test test/interactive-mode-mcp-connecting.test.ts test/interactive-mode-lsp-startup.test.ts, which failed before the fix with3 pass, 2 fail.Cause
packages/coding-agent/src/sdk.tsemittedMCP_CONNECTING_EVENT_CHANNELandLSP_STARTUP_EVENT_CHANNELwhenever UI was available, without checkingsettings.get("startup.quiet");packages/coding-agent/src/modes/interactive-mode.tsalso rendered those events without consulting the same setting.Fix
createAgentSessionwhenstartup.quietis enabled.createAgentSessionwhenstartup.quietis enabled.InteractiveModesubscriber guards so externally emitted startup events stay quiet.Verification
cd packages/coding-agent && bun test test/interactive-mode-mcp-connecting.test.ts test/interactive-mode-lsp-startup.test.tspassed with5 pass, 0 fail;cd packages/coding-agent && bun run checkpassed. Fixes #2639