Obanyc 3812 #146
Open
Obanyc 3812 #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Service Impl. After getting that done, we begin testing.
…t. Still need to implement a "switching" methodology that will allow us to use either ZMQ or Kafka without code modifications. This should be about ready to test.
…hat was not created before.
carabalb
reviewed
Apr 24, 2025
| } | ||
|
|
||
| public void startListenerThread() { | ||
| if (_initialized == true) { |
Collaborator
There was a problem hiding this comment.
Please confirm if this is actually needed. Historically the DummyPartitionedInputQueueListener didn't actually implement any logic, and was simply a place holder.
| public String getQueueName() { | ||
| return _configurationService.getConfigurationValueAsString( | ||
| "inference-engine.outputQueueName", null); | ||
| "inference-engine.outputQueueName", "bhs_queue"); |
Collaborator
There was a problem hiding this comment.
This isn't the right outputQueueName. We should probably avoid setting any defaults here to make it explicit that these need to be set.
Collaborator
There was a problem hiding this comment.
Is it possible to swap between ZMQ and Kafka without code changes?
…. Included is some streamlining and removal of duplicate code in lots of places for the IE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.