Skip 'Element' suffix for common elements #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
commented
Oct 15, 2025
Comment on lines
4
to
5
| from pals_schema.BaseElement import BaseElement | ||
| from pals_schema.ThickElement import ThickElement |
There was a problem hiding this comment.
I kept the Element suffix for the base element class and the thick element class, because naming them simply Base and Thick sounds a bit odd to me, but let me know if you want to rename those as well.
There was a problem hiding this comment.
yes, that is perfect for the mixin/base classes 👍
ax3l
reviewed
Oct 15, 2025
Comment on lines
+10
to
+11
| from pals_schema.Drift import Drift | ||
| from pals_schema.Quadrupole import Quadrupole |
There was a problem hiding this comment.
Perfect, thank you!
In a follow-up PR, can you please check if we want to write simply
from pals import Drift, Quadrupole, BeamlineIf empty/specific __init__.py files are missing we can add them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the
Elementsuffix for common elements such as drifts, quadrupoles, etc., and close #27.