Skip to content

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Sep 23, 2025

No description provided.

@EZoni EZoni requested a review from ax3l September 23, 2025 01:18
@EZoni EZoni added the documentation Improvements or additions to documentation label Sep 23, 2025
@EZoni EZoni force-pushed the update_copyright_license branch from 2ab5f3b to ec80649 Compare September 23, 2025 01:27
@ax3l
Copy link
Member

ax3l commented Sep 23, 2025

Thanks! Please also add a section at the end of the README.txt, e.g., as in https://github.com/BLAST-ImpactX/impactx?tab=readme-ov-file#copyright-notice

@EZoni
Copy link
Member Author

EZoni commented Sep 23, 2025

@ax3l

Thanks, added a section at the end of the README file. This should be ready to approve and merge.

README.md Outdated
please contact Berkeley Lab's Intellectual Property Office at
[email protected].

Please find the full copyright notice in [COPYRIGHT.txt](COPYRIGHT.txt) and the full license agreement in [LICENSE.txt](LICENSE.txt).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind renaming the COPYRIGHT.txt to NOTICE.txt to avoid confusion with the license text (as we did in ImpactX)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8589039.

@EZoni
Copy link
Member Author

EZoni commented Sep 23, 2025

@ax3l

I renamed COPYRIGHT.txt as NOTICE.txt and added the license identifier at the end of the README in the latest commit.

@EZoni EZoni requested a review from ax3l September 23, 2025 18:57
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ax3l ax3l merged commit f7b9dbb into campa-consortium:main Sep 24, 2025
11 checks passed
@EZoni EZoni deleted the update_copyright_license branch October 2, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants