Delete socket file before starting server #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Dream is started as a Unix socket server, then try to delete the socket file before binding to it. If it doesn't exist, just carry on. Fix #398
Collaborator
|
Thanks! Commented on this in #398 (comment), because there are more participants there and people linking to expertise outside OCaml. |
Collaborator
|
Leaving myself a reminder to have this PR close #399 when merging. |
Otherwise ignore the file–don't delete it. In this case we want to force the user to take care of the conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Dream is started as a Unix socket server, then try to delete the socket file before binding to it. If it doesn't exist, just carry on.
Second attempt at #399
Fix #398