[Quality-on-demand]: Remove unnecessary allOf from SessionInfo.device definition #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravindrapalaskar17
requested review from
RandyLevensalor,
eric-murray,
hdamker and
jlurien
as code owners
Contributor
Author
|
We’ve identified an alternative solution to resolve the model generation issue, so this PR is no longer required. Thanks to everyone who reviewed and contributed to the discussion! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR removes an unnecessary allOf wrapper from the device property in the SessionInfo schema.
The current use of allOf causes OpenAPI code generators to create an additional synthetic class (SessionInfoAllOfDevice), leading to compilation errors and inconsistent model mappings.
By defining the property directly using a $ref, the generated models remain clean,
Which issue(s) this PR fixes:
Fixes #505