Fix minor issues and typos in test plan #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandopradocabrillo
requested review from
RandyLevensalor,
eric-murray,
hdamker and
jlurien
as code owners
hdamker
previously approved these changes
Sep 9, 2025
Collaborator
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
Thanks a lot @fernandopradocabrillo for correcting the critical mismatches with the API definition and all the improvements of readability.
As this is probably based on actual use of the the release candidate version of the .feature files - would you mind to leave a statements in #492 and/or #493 after the PR is merged and the bugs are fixed for M4?
hdamker
reviewed
Sep 9, 2025
code/Test_definitions/qos-provisioning-getQosAssignmentByDevice.feature
Outdated
Show resolved
Hide resolved
RandyLevensalor
approved these changes
Sep 9, 2025
Contributor
Author
|
@hdamker as I have no power here, would you mind merging the PR? Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Fix minor issues and typos in test plan for M4
Which issue(s) this PR fixes:
Fixes #503