Skip to content

Conversation

@eric-murray
Copy link
Collaborator

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

lastStatusTime is an optional parameter in the 200 responses of the status APIs. But there is no good reason not to include this parameter. Otherwise, there is the risk of ambiguity as to whether the returned status is still valid. It should be mandatory for any status that is not current, and the simplest way to enforce that is to make it mandatory for all responses.

Which issue(s) this PR fixes:

Fixes #138

Special notes for reviewers:

Could be part of Spring'25 meta-release if approved and merged today

Changelog input

 release-note
 - Make lastStatusTime mandatory in 200 responses of the status APIs

Additional documentation

None

@akoshunyadi
Copy link
Collaborator

Is this PR meant for Spring25?

@eric-murray
Copy link
Collaborator Author

Is this PR meant for Spring25?

It could be a solution to #138, which is tagged Spring25. But there may not be time to agree and merge this before the Sping25 release, in which case it will have to wait.

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo
Copy link
Collaborator

fernandopradocabrillo commented Apr 23, 2025

Changing a reponse property from optional to required is a breaking change, we'll need to have this into consideration for Fall25, specially for roaming and reachability which are already in stable v1.0

@eric-murray
Copy link
Collaborator Author

Changing a reponse property from optional to required is a breaking change, we'll need to have this into consideration for Fall25, specially for roaming and reachability which are already in stable v1.0

It's not a breaking change for the client, so a "v1" client will still work, even with this change

@eric-murray
Copy link
Collaborator Author

PRs now raised in new repositories to implement this:
camaraproject/DeviceReachabilityStatus#18
camaraproject/DeviceRoamingStatus#19
camaraproject/ConnectedNetworkType#17

@eric-murray eric-murray closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to respond if queried device does not have an active session?

5 participants