Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer @data annotations #1456

Merged
merged 12 commits into from
May 10, 2023
Merged

Infer @data annotations #1456

merged 12 commits into from
May 10, 2023

Conversation

rachitnigam
Copy link
Contributor

Fixes #1169.

@rachitnigam rachitnigam mentioned this pull request May 9, 2023
Open
6 tasks
@rachitnigam
Copy link
Contributor Author

This is one of those features that I expect to make some significant effect on quality of results and therefore should be studied for the paper (#1440)

@rachitnigam rachitnigam added this to the Quality of Results milestone May 9, 2023
@rachitnigam
Copy link
Contributor Author

Another reason to deprecate std memories (#1261): the addr ports on those memories cannot be marked @data because reads are always active and therefore will writing 'x to the address will trigger the sanity check assert in Verilator

@rachitnigam rachitnigam merged commit 0538164 into master May 10, 2023
@rachitnigam rachitnigam deleted the data-path-infer branch May 10, 2023 04:23
@sampsyo
Copy link
Contributor

sampsyo commented May 10, 2023

Wonderful. Yes, it would be very interesting to see how this affects synthesis results. I have no intuition to bring to bear on how much the synthesis could "second-guess" this type of stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Quality of Results
Development

Successfully merging this pull request may close these issues.

Annotations for Data Path Components
2 participants
@rachitnigam @sampsyo