Some miscellaneous builder improvements #1296
Conversation
...and also implicitly import the newish `memories` header, which has the seq_mem components.
This thought it was a format string but it was not.
I wrote in my builder `mem.addr0 = reg` instead of `mem.addr0 = reg.out`. The confusing error happened on code *generation*. This makes the problem a bit more visible.
|
Ah, I ended up making some of these changes in #1295 as well. Also, the interpreter does not support sequential memories so importing it default might be breaking things? In general, I’d like to revisit the decision to have a default import list include at all |
| if prim == "seq_mem_d1": | ||
| if port_name == "read_en": |
There was a problem hiding this comment.
| if prim == "seq_mem_d1": | |
| if port_name == "read_en": | |
| if prim == "seq_mem_d1" and port_name == "read_en": |
There was a problem hiding this comment.
I was thinking this and then skipped over the simplification to emphasize the outer case, which adds a different set of ports (which happens to be a set of size 1)… hope that's cool!
Ah, nice—sorry for the race condition!! I'll let that one go first, and then fix this one up to adapt.
Good idea. Maybe we can implicitly import the first time you use a thing. Or maybe we want to offer some way to explicitly access things from the various libraries. Or maybe just the simplest/dumbest thing, which is that you have to explicitly ask to build imports (that's probably the right way). |
...and also support != for not-equals.
We now *implicitly* import the `binary_operators` whenever you use `add`. Of course we should probably add more of these implicit imports for other stuff... and someday rethink the whole interface for importing stuff from libraries.
|
I added a new explicit function |
| @@ -99,8 +99,14 @@ def comb_group(self, name: str) -> "GroupBuilder": | |||
| return builder | |||
|
|
|||
| def cell( | |||
| self, name: str, comp: ast.CompInst, is_external=False, is_ref=False | |||
| self, name: str, comp: Union[ast.CompInst, "ComponentBuilder"], | |||
| is_external=False, is_ref=False | |||
| ) -> "CellBuilder": | |||
There was a problem hiding this comment.
How can this feature be used? Or maybe, how does it show up in code?
There was a problem hiding this comment.
It's for instantiating components that you just recently built with the builder! Like this in AOC day 1:
https://github.com/cucapra/aoc2022-calyx/blob/e63cff9055fa7e183dabab6993f2dee26376e6ab/1/accelgen.py#L103
|
LGTM! |
Just a few holes addressed on the journey to #1240. Not much exciting to see here. I also happened across a mistake in a fud error message and fixed that too.