Skip to content

Fixed typos for Resurrection Balm and Leather Baldric #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

josefwk
Copy link
Contributor

@josefwk josefwk commented Feb 7, 2025

See title. Changes the unidentified name for Leather Baldric (which was "Leather Baldri") and fixes a typo in the name of Resurrection Balm (was "Ressurection Balm").

@josefwk
Copy link
Contributor Author

josefwk commented Feb 7, 2025

So there are other instances of these typos in the following files, not sure if they should be modified or preserved:

  • rsrc/scenarios/busywork/items.xml
  • rsrc/scenarios/stealth/items.xml
  • rsrc/scenarios/valleydy/items.xml
  • rsrc/scenarios/zakhazi/items.xml
  • test/files/town/townRectUniversal/items.xml
  • test/replays/scenarios/use-special-terrain/items.xml

Pushed corrections to these files as well in the interest of expediting the PR, can always cherry pick or request changes.

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Feb 7, 2025

I'll merge this as soon as possible, but it'll need to be cherry-picked to the scen_update branch (#338) too (which would omit the test scenarios). It might take me a bit of time to get to that, though you're also welcome to do that yourself in a second PR.

@CelticMinstrel CelticMinstrel merged commit f22f248 into calref:master Feb 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants