refactor: split federation runtime plugin into separate plugins #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1889155 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thymikee
reviewed
Nov 27, 2024
thymikee
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splitting the runtime plugin in order to enable more granular control. FederationRuntimePlugin now becomes two runtime plugins:
Users can modify which default plugins are included via
defaultRuntimePluginsin the MF2 Plugin config. For example, if users want to opt out of theResolverPluginthey can set the prop to['@callstack/repack/mf/core-plugin']in order to include just theCorePlugin.ResolverPlugin can be configured similar to how
RetryPluginfrom MF2 core: https://module-federation.io/plugin/plugins/retry-plugin.html#usage (i.e. creating own runtime plugin that wraps the ResolverPlugin)Test plan