fix: nativewind broken by import source being overwritten in default case #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c943fc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dannyhw
force-pushed
the
dannyhw/fix/nativewind-importsource-overwritten
branch
from
3dfd4ec to
d658a9c
Compare
jbroma
reviewed
Dec 9, 2025
Member
|
btw @dannyhw we should totally have unit tests for this and test the possible scenarios 💯 |
Collaborator
Author
|
tests added 👍 |
Member
|
@dannyhw can you please add changeset entry? Run |
Collaborator
Author
|
On it 👍 |
dannyhw
force-pushed
the
dannyhw/fix/nativewind-importsource-overwritten
branch
from
1ba47db to
69e781e
Compare
…case fix: use a better fallback docs: remove some notes that are no longer necessary docs: more clarification docs: fix formatting and wording moving docs changes to separate pr review: inline default values test: add coverage for react transforms being included fix: add changeset fix: adjust changeset fix: adjust changeset
dannyhw
force-pushed
the
dannyhw/fix/nativewind-importsource-overwritten
branch
from
69e781e to
c943fc9
Compare
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1312 #1295
Summary
Fixes NativeWind integration being broken when using SWC loader.
The issue was in
getTransformReactRuntimeConfigwhich unconditionally overwroteruntimeandimportSourcefromreactRuntimeConfig, even when those values wereundefined. This would clobber the customimportSourcethat NativeWind sets in the SWC config (e.g.,nativewind).The fix uses nullish coalescing (
??) to preserve existing values whenreactRuntimeConfigdoesn't provide overrides.Test plan
importSourcewas overwritten)