-
Notifications
You must be signed in to change notification settings - Fork 153
fix: use import default esm helper for esm path imports #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7aefdc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1290
This PR introduces
importDefaultESMhelper for dynamic imports of modules that works across both MacOS and WindowsTest plan
Note
Normalize dynamic ESM imports (via new helper and fileURL) to fix Windows
ERR_UNSUPPORTED_ESM_URL_SCHEMEand update call sites accordingly.importDefaultESMinpackages/repack/src/helpers/helpers.tsto normalize dynamic ESM imports via file URLs and returndefaultwhen present.getMinimizerConfig.ts: Loadterser-webpack-pluginviaimportDefaultESM.getDevMiddleware.ts: Import@react-native/dev-middlewareusingurl.pathToFileURL(...).babelLoader/utils.ts: Loadhermes-parserviaimportDefaultESM.babelSwcLoader/utils.ts: Load@rspack/coreand@swc/coreviaimportDefaultESM; addRspacktype and simplify SWC resolution logic.ERR_UNSUPPORTED_ESM_URL_SCHEMEon Windows.Written by Cursor Bugbot for commit 7aefdc6. This will update automatically on new commits. Configure here.