Skip to content

Conversation

@fabioh8010
Copy link
Collaborator

Summary

This PR upgrades the native-cli example to use the latest packages.

Test plan

  1. Assert all CI checks pass.

@github-actions
Copy link

Performance Comparison Report

  • Current: ed43ae7 - 2025-05-19 16:44:47Z
  • Baseline: main (9f029dc) - 2025-05-19 16:44:22Z

Significant Changes To Duration

Show entries
Name Type Duration Count
RN CLI - TestList (100 items) render 9.8 ms → 8.8 ms (-0.9 ms, -9.7%) 🟢 1 → 1
RN CLI - AsyncComponent (10 runs) render 32.6 ms → 29.2 ms (-3.5 ms, -10.6%) 🟢 2 → 2
RN CLI - AsyncComponent (50 runs) render 33.0 ms → 29.1 ms (-4.0 ms, -12.0%) 🟢 2 → 2.02 (+0.02, +1.0%)
Show details
Name Type Duration Count
RN CLI - TestList (100 items) render Baseline
Mean: 9.8 ms
Stdev: 0.1 ms (1.2%)
Runs: 10.0 9.8 9.6 9.7 9.9 9.8 9.8 9.8 9.6 9.7
Warmup runs: 18.3

Current
Mean: 8.8 ms
Stdev: 0.1 ms (1.4%)
Runs: 9.1 8.7 8.8 8.9 8.7 8.9 8.6 8.9 8.8 8.8
Warmup runs: 38.2
Removed outliers: (none)
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
RN CLI - AsyncComponent (10 runs) render Baseline
Mean: 32.6 ms
Stdev: 0.2 ms (0.7%)
Runs: 32.4 32.9 32.5 33.0 32.3 32.8 32.5 32.7 32.7 32.5
Warmup runs: 1514.0

Current
Mean: 29.2 ms
Stdev: 0.4 ms (1.5%)
Runs: 28.6 29.1 30.1 29.6 29.2 29.1 28.8 29.1 29.0 29.1
Warmup runs: 1664.9
Removed outliers: (none)
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
RN CLI - AsyncComponent (50 runs) render Baseline
Mean: 33.0 ms
Stdev: 0.5 ms (1.6%)
Runs: 32.5 33.3 32.9 32.9 32.9 32.8 32.7 33.2 33.1 32.8 33.0 32.7 33.1 32.4 32.6 34.0 32.6 32.7 32.6 32.7 36.1 32.7 33.1 33.1 33.4 33.3 32.9 32.8 32.8 32.9 32.9 32.8 32.8 32.7 32.9 33.0 33.0 32.9 33.2 32.8 32.9 32.7 33.1 33.4 33.4 33.6 33.2 33.1 33.7 32.9
Warmup runs: 33.3

Current
Mean: 29.1 ms
Stdev: 0.4 ms (1.3%)
Runs: 29.1 29.3 29.2 29.4 29.3 29.2 29.1 28.8 29.2 28.7 29.1 28.9 29.2 29.3 29.0 29.1 28.8 29.0 29.1 29.1 29.3 31.1 28.8 29.1 28.9 28.9 29.0 29.0 28.7 28.9 29.0 28.7 29.1 29.0 29.1 29.1 29.2 29.2 28.6 29.1 28.8 28.9 29.7 28.8 29.1 28.5 29.2 29.1 28.9
Warmup runs: 29.2
Removed outliers: 38.7
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
Render issues:

Current
Mean: 2.02
Stdev: 0.14 (7.0%)
Runs: 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 3 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
Render issues:

Meaningless Changes To Duration

There are no entries

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against 077c015

@fabioh8010 fabioh8010 requested a review from mdjastrzebski May 19, 2025 16:45
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdjastrzebski mdjastrzebski merged commit b2d330f into main May 20, 2025
2 checks passed
@mdjastrzebski mdjastrzebski deleted the feature/upgrade-cli-example branch May 20, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants