-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Update react-native to 0.82 #4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e680499
3b4a00f
b5ab386
579ff64
046237e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neat! 🔥 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ | |
| }, | ||
| "dependencies": { | ||
| "@callstack/react-theme-provider": "^3.0.9", | ||
| "@react-native/babel-preset": "^0.82.1", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should be at most but... I would avoid the preset altogether since every project will use that preset with it's own babel config. In theory, running the preset in the lib should reduce the transpilation time of the library in the projects, but every file still is going to be parsed by babel and then (most likely, needs verifying) transformations will try to run again but will result in
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. iirc it's needed for tests etc. the lib isn't actually compiled with this since bob has an internal Babel config unless overridden. the main benefit of precompiling is to make it seamlessly work with anything other than metro (jest, vite, webpack) since they don't compile |
||
| "color": "^3.1.2", | ||
| "use-latest-callback": "^0.2.3" | ||
| }, | ||
|
|
@@ -69,9 +70,9 @@ | |
| "@types/color": "^3.0.0", | ||
| "@types/jest": "^29.2.1", | ||
| "@types/node": "^13.1.0", | ||
| "@types/react-dom": "^18.3.1", | ||
| "@types/react-dom": "^19.1.1", | ||
| "@types/react-native-vector-icons": "^6.4.18", | ||
| "@types/react-test-renderer": "^18.3.0", | ||
| "@types/react-test-renderer": "^19.1.0", | ||
| "@typescript-eslint/eslint-plugin": "^5.41.0", | ||
| "@typescript-eslint/parser": "^5.41.0", | ||
| "all-contributors-cli": "^6.24.0", | ||
|
|
@@ -92,15 +93,15 @@ | |
| "jest": "^29.6.3", | ||
| "jest-file-snapshot": "^0.3.2", | ||
| "metro-react-native-babel-preset": "0.73.9", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be removed since this is deprecated nowadays |
||
| "react": "18.3.1", | ||
| "react": "19.1.1", | ||
| "react-dom": "18.3.1", | ||
| "react-native": "0.77.0", | ||
| "react-native": "0.82.1", | ||
| "react-native-builder-bob": "^0.21.3", | ||
| "react-native-safe-area-context": "5.1.0", | ||
| "react-test-renderer": "18.3.1", | ||
| "react-native-safe-area-context": "5.5.2", | ||
| "react-test-renderer": "19.1.1", | ||
| "release-it": "^13.4.0", | ||
| "rimraf": "^3.0.2", | ||
| "typescript": "5.0.4" | ||
| "typescript": "5.8.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "*", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import React from 'react'; | ||
| import React, { JSX } from 'react'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't be needed to import this, probably a configuration issue somewhere There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 |
||
| import { Animated, Platform, View, ViewProps } from 'react-native'; | ||
|
|
||
| interface Props extends ViewProps { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import * as React from 'react'; | ||
| import { JSX } from 'react'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't be needed to import this, probably a configuration issue somewhere |
||
| import { | ||
| Animated, | ||
| I18nManager, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import * as React from 'react'; | ||
| import { JSX } from 'react'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't be needed to import this, probably a configuration issue somewhere |
||
| import { | ||
| I18nManager, | ||
| StyleProp, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[tiny q] - Just checking, do we still need the
// @ts-ignoresince there’s already an ESLint disable on the next line?And do we know the reason for all the ESLint disables here? Trying to understand whether this is expected or if we’re missing something.