-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: remove isV3 and MD2 from components
#4727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
63575e3 to
270cc44
Compare
3121d9f to
6e4785c
Compare
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #4725
Motivation
Removed
isV3from components:All references to the isV3 variable or property have been removed from components and utilities, eliminating conditional logic based on theme version.
Destructured Theme Prop:
Components now consistently destructure the theme prop to directly access colors, fonts, and other theme properties, improving code readability and maintainability.
Removed v2 Colors:
All usage of v2 color tokens (such as
MD2Colors) has been removed. Components now use the latest color tokens from the theme, ensuring consistency and alignment with the current design system.