fix: handle change in tabler svg tag from oneline to multiline #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nb: currently untested; not sure how to or if I can execute GitHub Actions against my fork a la |
|
Thanks! I'll have a proper look later today. You can test the workflow on your branch by changing the uses: value: https://github.com/caksoylar/zmk-config/blob/main/.github/workflows/draw-keymaps.yml#L14 |
|
Success! That flag does indeed fix it. FWIW, I also had to change the install line in my |
|
FYI, going to back out that install line change in this branch so that this is actually mergeable again. |
|
Thank you! This works and I think this is the right way to fix it. |
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
re.DOTALLflag to ignore newlines in regex looking forviewBoxattribute insvgtag to address #81