-
Notifications
You must be signed in to change notification settings - Fork 888
Update phpunit to ^10.5 #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update phpunit to ^10.5 #2381
Changes from all commits
c978ce0
4fc94f5
62d08f9
d45647a
83cf5ef
d7eff35
515014a
85e2765
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,7 +102,7 @@ jobs: | |
| if [[ ${{ matrix.db-type }} == 'pgsql' ]]; then export PGSQL_DSN='pgsql://postgres:[email protected]/phinx'; fi | ||
|
|
||
| if [[ ${{ matrix.prefer-lowest != 'prefer-lowest' }} ]]; then | ||
| export CODECOVERAGE=1 && vendor/bin/phpunit --verbose --coverage-clover=coverage.xml | ||
| export CODECOVERAGE=1 && vendor/bin/phpunit --coverage-clover=coverage.xml | ||
| else | ||
| vendor/bin/phpunit | ||
| fi | ||
|
|
@@ -180,7 +180,7 @@ jobs: | |
| SQLSRV_DSN: 'sqlsrv://(localdb)\MSSQLLocalDB/phinx' | ||
| CODECOVERAGE: 1 | ||
| run: | | ||
| vendor/bin/phpunit --verbose --coverage-clover=coverage.xml | ||
| vendor/bin/phpunit --coverage-clover=coverage.xml | ||
|
|
||
| - name: Submit code coverage | ||
| uses: codecov/codecov-action@v5 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,13 @@ | |
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| /** | ||
| * Class AbstractConfigTest | ||
| * Class AbstractConfigTestCase | ||
| * | ||
| * @package Test\Phinx\Config | ||
| * @group config | ||
| * @coversNothing | ||
| */ | ||
| abstract class AbstractConfigTest extends TestCase | ||
| abstract class AbstractConfigTestCase extends TestCase | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed this as it wasn't a file that had tests, but rather something the concrete |
||
| { | ||
| /** | ||
| * @var string | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the biggest change would be no longer printing out the skipped tests, but I think that's actually preferable as they were essentially just noise for the most part and something to annoyingly scroll past to see actual test errors.
If we wanted to bring back the behavior, can use the new
--display-skippedflag ordisplayDetailsOnSkippedTestsXML option.