feature: dockerizeSamples #7355
Conversation
zawadzkidiana
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Why: - Current samples only support local machine setup - Need to support Kubernetes deployment scenarios - Simplify onboarding process for new users This change: - Adds Dockerfile for sample applications - Adds docker-compose.yml for local development - Adds documentation for Docker usage Testing: - Built and tested Docker image locally - Verified sample workflows run in containerized environment - Tested with docker-compose setup What's Next: - Add Kubernetes Helm charts - Set up CI/CD pipeline for Docker images - Add more sample workflows Related Issue: #<issue_number> Signed-off-by: Diana Zawadzki <[email protected]>
zawadzkidiana
force-pushed
the
feature/dockerize-samples
branch
from
d8ed76d to
a9e45b0
Compare
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
Signed-off-by: Diana Zawadzki <[email protected]>
zawadzkidiana
force-pushed
the
feature/dockerize-samples
branch
from
3603a60 to
9220a25
Compare
- Implemented basic Cadence worker service with YARPC/gRPC - Added helloWorldWorkflow that orchestrates activity execution - Added helloWorldActivity that returns greeting message - Included long-running workflow example for UI demonstration - Added comprehensive documentation (README, test results, completion guide) - Configured activity timeouts and error handling - Fully tested with multiple successful workflow executions
| ### Start Everything | ||
| ```bash | ||
| # 1. Start Cadence server | ||
| cd /Users/zawadzki/Uber/cadence |
There was a problem hiding this comment.
This command only applies to your own machine.
There was a problem hiding this comment.
Good catch - that was a machine-specific path.
I realized I was working in the wrong repo (this should be in cadence-samples, not cadence). Moving it there now and fixing all the paths. Will close this PR.
| @@ -1,4 +1,4 @@ | |||
| go 1.23.0 | |||
| go 1.25.2 | |||
There was a problem hiding this comment.
why are we updating the go language version?
| ) | ||
|
|
||
| // longRunningWorkflow demonstrates a workflow that stays open for a while | ||
| func longRunningWorkflow(ctx workflow.Context, name string) (*string, error) { |
There was a problem hiding this comment.
We have a bunch of samples defined in the samples repo. We should look into ways to use that instead of writing a new workflow
There was a problem hiding this comment.
@timl3136 You're right - I removed this file. The docker-samples now just has a minimal hello-world and points people to the main samples repo for more examples. No need to duplicate what already exists.
|
I think we have dockerized cadence-samples here |
|
Closing this PR - it was opened in the wrong repository. |
3 participants
What changed?
Why?
This is the initial setup for adding Docker support to Cadence samples. Having a clear structure from the start will help organize the implementation of:
How did you test it?
Potential risks
Release notes
N/A - Initial project structure only
Documentation Changes