Skip to content

Conversation

arzonus
Copy link
Contributor

@arzonus arzonus commented Oct 17, 2025

What changed?
Integration test for DescribeCluster has been added.

Why?
The lack of this test caused this #6338, and was fixed in #6350

The responses' variables depend on each run, so they cannot be asserted. The test asserts only that the API can return the response without errors.

How did you test it?
Run integration tests

Potential risks
No risks

@arzonus arzonus force-pushed the add-test-describe-cluster-test branch from 62555cd to e69bc85 Compare October 17, 2025 13:55
@arzonus arzonus merged commit 94d3d8c into cadence-workflow:master Oct 20, 2025
39 checks passed
instamitch pushed a commit to instamitch/cadence that referenced this pull request Oct 21, 2025
<!-- Describe what has changed in this PR -->
**What changed?**
Integration test for DescribeCluster has been added.

<!-- Tell your future self why have you made these changes -->
**Why?**
The lack of this test caused this
#[6338](cadence-workflow#6338), and was fixed in
cadence-workflow#6350

The responses' variables depend on each run, so they cannot be asserted.
The test asserts only that the API can return the response without
errors.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Run integration tests

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No risks

Signed-off-by: Seva Kaloshin <[email protected]>
Signed-off-by: Mitch O'Dea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants