chore: Upgrade grpc-go and yarpc#1494
chore: Upgrade grpc-go and yarpc#1494c-warren wants to merge 8 commits intocadence-workflow:masterfrom
Conversation
Code Review ✅ Approved 2 resolved / 2 findingsUpgrades grpc-go and yarpc dependencies with updated IDL package bindings and internal tooling, addressing leftover fork references and Go version inconsistencies. No remaining issues found. ✅ 2 resolved✅ Bug: Leftover replace directive in internal/tools/go.mod points to fork
✅ Quality: tools/go.mod downgrades minimum Go version from 1.23 to 1.21
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Closing this until we are ready to upgrade grpc-go. |
What changed?
Upgrades yarpc (and grpc-go) to get the latest fixes.
Why?
Staying up to date with yarpc's latest version ensures that we have the latest security fixes, functionality, etc. and do not depend on known broken versions.
How did you test it?
See: cadence-workflow/cadence-idl#255
This has been tested in our internal canary instances w/ the cadence-go-client and cadence using the upgraded fork, as well as updating their yarpc dependencies (and other transitive deps).
Potential risks
Worst case scenario will be incompatibility between cadence-go-client and an old cadence version, or vice-versa - old cadence-client versions unable to make requests to new cadence instances. This has been tested in dev canary, but will need to be continuously monitored.