Break long poll loop early when context remaining timeout is too low#1123
Open
vytautas-karpavicius wants to merge 3 commits intocadence-workflow:masterfrom
Open
Conversation
Pull Request Test Coverage Report for Build 045dc6fd-ee25-4797-9592-38002509929e
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Stop long poll on the client side when too little time is left on the context.
Why?
To prevent unnecessary call to the server will would timeout anyway.
Relate Server PR: cadence-workflow/cadence#4425
How did you test it?
Locally.
Potential risks