Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Caddy Test Configuration Defaults Override. #6850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Caddy Test Configuration Defaults Override. #6850

wants to merge 1 commit into from

Conversation

baruchyahalom
Copy link

While Running parallel Caddy testers, the hardcoded Admin port raised a requirement to allow overriding the default configuration.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@baruchyahalom baruchyahalom force-pushed the caddytest-defaults-override branch 2 times, most recently from 6a5da85 to 063e5b8 Compare February 19, 2025 21:20
mholt
mholt requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement! Just a couple thoughts before we merge it.

@baruchyahalom baruchyahalom force-pushed the caddytest-defaults-override branch from 063e5b8 to 0839f37 Compare February 20, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baruchyahalom @CLAassistant @mholt