Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade lint rules #475

Merged
merged 12 commits into from
Mar 10, 2023
Merged

Upgrade lint rules #475

merged 12 commits into from
Mar 10, 2023

Conversation

Youngdi
Copy link

@Youngdi Youngdi commented Mar 10, 2023 •
edited
Loading

  1. It upgraded and migrated all the lints to the latest one
  2. It removed the /packages/components
  3. It added one new package called @caddijp/prettier-config

@Youngdi Youngdi requested a review from laxa88 March 10, 2023 01:44
@Youngdi Youngdi self-assigned this Mar 10, 2023
@Youngdi Youngdi requested a review from cwvick March 10, 2023 01:46
@Youngdi Youngdi added the Type: Feature New Feature label Mar 10, 2023
laxa88
laxa88 approved these changes Mar 10, 2023
View reviewed changes
Copy link

@laxa88 laxa88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering about the failing CI 🙇

@Youngdi Youngdi merged commit ccfebaa into main-v0.5.x Mar 10, 2023
@Youngdi Youngdi deleted the upgrade_lint_rules branch March 10, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxa88 laxa88 laxa88 approved these changes

@cwvick cwvick Awaiting requested review from cwvick

Assignees

@Youngdi Youngdi

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youngdi @laxa88